[libvirt PATCH 5/5] qemu: wire up support for maximum CPU model

[Daniel P. Berrangé]

On Tue, Feb 09, 2021 at 02:21:32PM +0000, Richard W.M. Jones wrote:
> 
> Patch series looks fine to me, and we can certainly use this feature.
> 
> One question I have about it: Does this apply to all architectures
> equally, or will we need to detect it from capabilities?  I mean to
> say, if this was added to libvirt version X, then I might mandate that
> you have to use libvirt >= X and not bother detecting it (as the
> feature is so useful).  But if it applies only on some architectures
> then we'd have to detect it anyway.

Most but not all QEMU architectures. riscv64 is a notable one that
lacks "-cpu max" in QEMU. For that matter, it may well lack
"-cpu host" too from what i see ?


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|