[libvirt PATCH v2 4/4] ci: Makefile: Expose the CI_USER_LOGIN variable for users to use

Andrea Bolognani abologna at redhat.com
Fri Feb 12 15:04:04 UTC 2021


On Fri, 2021-02-12 at 15:19 +0100, Erik Skultety wrote:
> @@ -239,6 +241,7 @@ ci-help:
>  	@echo "    CI_CLEAN=0          - do not delete '$(CI_SCRATCHDIR)' after completion"
>  	@echo "    CI_REUSE=1          - re-use existing '$(CI_SCRATCHDIR)' content"
>  	@echo "    CI_ENGINE=auto      - container engine to use (podman, docker)"
> +	@echo "    CI_USER_LOGIN=$$USER      - which user should run in the container"

Alignment is completely broken here. But I just realized that $USER
will get expanded here, so we have basically no way of keeping that
consistent...

Basically, your original version of the help message was better,
please go back to that one :)

Reviewed-by: Andrea Bolognani <abologna at redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization




More information about the libvir-list mailing list