[PATCH 00/25] Clear pointers in virJSONValue(Object|Array)Append and other cleanups

[Michal Privoznik]

On 2/12/21 6:55 PM, Peter Krempa wrote:
> Peter Krempa (25):
>    virLockDaemonPreExecRestart: Refactor memory cleanup
>    virLogDaemonPreExecRestart: Refactor memory cleanup
>    virLogHandlerPreExecRestart: Refactor memory cleanup
>    virNetDaemonPreExecRestart: Refactor memory cleanup
>    virNetServerServicePreExecRestart: Refactor memory cleanup
>    virNetServerClientPreExecRestart: Refactor memory cleanup
>    virNetServerPreExecRestart: Drop error reporting from
>      virJSONValueObjectAppend* calls
>    virNetServerPreExecRestart: Refactor memory cleanup
>    virLockSpacePreExecRestart: Refactor memory cleanup
>    qemuAgentMakeCommand: Refactor memory cleanup
>    virJSONValueObjectInsert: Clear @value on successful insertion
>    virJSONValueCopy: Don't use virJSONValue(Object|Array)Append
>    virJSONValue(Array|Object)Append*: Simplify handling of appended
>      object
>    virJSONValueNewArrayFromBitmap: Refactor cleanup
>    virJSONValueObjectAddVArgs: Use autofree for the temporary bitmap
>    virJSONValueObjectAppend: Clear pointer when taking ownership of
>      passed value
>    qemuAgentMakeStringsArray: Refactor cleanup
>    virMACMapHashDumper: Refactor array addition
>    testQEMUSchemaValidateObjectMergeVariantMember: Fix theoretical leak
>    virJSONValueArrayAppend: Clear pointer when taking ownership of passed
>      value
>    qemuMonitorJSONTransactionAdd: Refactor cleanup
>    qemuAgentSetVCPUsCommand: Refactor cleanup
>    virJSONParserHandle*: Refactor memory cleanup and drop NULL checks
>    virJSONValueNewNumber: Take ownership of passed string
>    virJSONParserInsertValue: Take double pointer for @value
> 
>   src/locking/lock_daemon.c            |  77 ++++----
>   src/logging/log_daemon.c             |  52 +++---
>   src/logging/log_handler.c            |  40 ++--
>   src/network/leaseshelper.c           |   3 +-
>   src/node_device/node_device_driver.c |   4 +-
>   src/qemu/qemu_agent.c                |  89 ++++-----
>   src/qemu/qemu_block.c                |  19 +-
>   src/qemu/qemu_command.c              |   3 +-
>   src/qemu/qemu_firmware.c             |  27 +--
>   src/qemu/qemu_migration_params.c     |   4 +-
>   src/qemu/qemu_monitor_json.c         |  58 +++---
>   src/rpc/virnetdaemon.c               |  25 +--
>   src/rpc/virnetserver.c               |  79 +++-----
>   src/rpc/virnetserverclient.c         |  24 +--
>   src/rpc/virnetserverservice.c        |  34 ++--
>   src/util/virjson.c                   | 261 +++++++++++----------------
>   src/util/virjson.h                   |   7 +-
>   src/util/virlease.c                  |   2 +-
>   src/util/virlockspace.c              |  47 ++---
>   src/util/virmacmap.c                 |  13 +-
>   tests/testutilsqemuschema.c          |   4 +-
>   21 files changed, 322 insertions(+), 550 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn at redhat.com>

Michal