[PATCH 3/3] qemu: Don't lie about @ndevAlias when translating FSInfo

[Ján Tomko]

On a Monday in 2021, Michal Privoznik wrote:
>When virDomainGetFSInfo() is called over a QEMU/KVM domain it
>results into calling of 'guest-get-fsinfo' guest agent command to
>which it replies with info on guest (mounted) filesystems. When
>filling return structure we also try to do basic lookup and
>translate guest agent provided disk address into disk target (as
>seen in domain XML). This can of course fail - guest can have
>variety of disks not recorded in domain XML (iSCSI, scsi_debug,
>NFS to name a few). If that's the case, a debug message is logged
>and no disk target is added into the return structure.
>
>However, due to the way our code is written the caller is led to
>believe that the target was added into the structure. This may
>lead to a situation where the array of disk targets (strings)
>contains NULL. But our RPC structure says the array contains only
>non-NULL strings. This results in somewhat 'cryptic' (at least to
>users) error message:
>
>  error: Unable to get filesystem information
>  error: Unable to encode message payload
>
>Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1919783
>Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
>---
> src/qemu/qemu_driver.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20210215/9edab47f/attachment-0001.sig>