[PATCH 1/3] api: Discourage use of VIR_DOMAIN_SNAPSHOT_CREATE_QUIESCE

Pavel Hrdina phrdina at redhat.com
Mon Feb 15 18:03:11 UTC 2021


On Mon, Feb 15, 2021 at 06:27:49PM +0100, Peter Krempa wrote:
> The flag creates additional points of failure which are hard to recover
> from, such as when thawing of the filesystems fails after an otherwise
> successful snapshot.
> 
> Encougage use of explicit virDomainFSFreeze/virDomainFSThaw.

s/Encougage/Encourage/

> 
> Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> ---
>  src/libvirt-domain-snapshot.c | 3 +++
>  1 file changed, 3 insertions(+)

Reviewed-by: Pavel Hrdina <phrdina at redhat.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20210215/26baac90/attachment-0001.sig>


More information about the libvir-list mailing list