[PATCH 3/3] qemuSnapshotFSFreeze: Don't return -2
Pavel Hrdina
phrdina at redhat.com
Mon Feb 15 18:20:25 UTC 2021
On Mon, Feb 15, 2021 at 06:27:51PM +0100, Peter Krempa wrote:
> The -2 value is misleading because if 'qemuAgentFSFreeze' fails it
> doesn't necessarily mean that the command was sent to the agent.
>
> Since callers don't care about the -2 value specifically, remove it.
In addition this indirectly fixes virDomainFSFreeze public API where
we return result of qemuSnapshotFSFreeze directly. Now we comply with
the API description.
> Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> ---
> src/qemu/qemu_snapshot.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
Reviewed-by: Pavel Hrdina <phrdina at redhat.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20210215/d17275e1/attachment-0001.sig>
More information about the libvir-list
mailing list