[libvirt PATCH 3/5] qemu: use on|off instead of yes|no for -object boolean properties

Daniel P. Berrangé berrange at redhat.com
Tue Feb 16 13:26:38 UTC 2021


On Tue, Feb 16, 2021 at 02:21:56PM +0100, Peter Krempa wrote:
> On Tue, Feb 16, 2021 at 12:57:03 +0000, Daniel Berrange wrote:
> > QEMU has long accepted many different values for boolean properties, but
> > set accepted has been different depending on which QEMU parser you hit.
> > 
> > The on|off values were supported by all QEMU parsers. The yes|no, y|n,
> > true|false values were only partially supported:
> > 
> >   https://lists.gnu.org/archive/html/qemu-devel/2020-11/msg01012.html
> > 
> > Thus we should standardize on on|off everywhere since that is most
> > widely supported in QEMU.
> > 
> > Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
> > ---
> 
> [...]
> 
> >  mode change 120000 => 100644 tests/qemuxml2argvdata/aarch64-gic-default-both.args
> >  mode change 120000 => 100644 tests/qemuxml2argvdata/aarch64-gic-default-v2.args
> >  mode change 120000 => 100644 tests/qemuxml2argvdata/aarch64-gic-default-v3.args
> >  mode change 120000 => 100644 tests/qemuxml2argvdata/aarch64-gic-default.args
> >  mode change 120000 => 100644 tests/qemuxml2argvdata/aarch64-gic-none-both.args
> >  mode change 120000 => 100644 tests/qemuxml2argvdata/aarch64-gic-none-v2.args
> >  mode change 120000 => 100644 tests/qemuxml2argvdata/aarch64-gic-none-v3.args
> >  mode change 120000 => 100644 tests/qemuxml2argvdata/aarch64-gic-none.args
> >  mode change 120000 => 100644 tests/qemuxml2argvdata/cpu-check-full.args
> >  mode change 120000 => 100644 tests/qemuxml2argvdata/cpu-check-partial.args
> >  mode change 120000 => 100644 tests/qemuxml2argvdata/disk-backing-chains-index.x86_64-2.12.0.args
> >  mode change 120000 => 100644 tests/qemuxml2argvdata/disk-backing-chains-index.x86_64-latest.args
> >  mode change 120000 => 100644 tests/qemuxml2argvdata/mach-virt-console-native.args
> >  mode change 120000 => 100644 tests/qemuxml2argvdata/mach-virt-serial+console-native.args
> >  mode change 120000 => 100644 tests/qemuxml2argvdata/mach-virt-serial-compat.args
> >  mode change 120000 => 100644 tests/qemuxml2argvdata/pci-rom-disabled-invalid.args
> >  mode change 120000 => 100644 tests/qemuxml2argvdata/pseries-console-native.args
> >  mode change 120000 => 100644 tests/qemuxml2argvdata/pseries-serial+console-native.args
> >  mode change 120000 => 100644 tests/qemuxml2argvdata/pseries-serial-compat.args
> >  mode change 120000 => 100644 tests/qemuxml2argvdata/user-aliases2.args
> 
> Any particular reason why these are converted from symlink to full file?

Urgh, yet again. I hate these symlinks :=(

It happens whenever you do a in-place search-replace with sed/perl/etc


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




More information about the libvir-list mailing list