[libvirt PATCH 0/9] eliminate (almost) all VIR_FREE in esx directory

[Andrea Bolognani]

On Wed, 2021-02-17 at 10:44 +0100, Ján Tomko wrote:
> On a Wednesday in 2021, Andrea Bolognani wrote:
> > On Fri, 2021-02-12 at 17:07 -0500, Laine Stump wrote:
> > > Laine Stump (9):
> > >   esx: use g_autofree for char* where it is trivially possible
> > >   esx: use g_autofree when made possible by reducing scope
> > >   esx: fix memory leak by switching to g_autofree
> > >   esx: switch VIR_FREE->g_free in esx*Free*()
> > >   esx: use g_steal_pointer+g_autofree on return value
> > >   esx: reorder code to avoid need to VIR_FREE mimeType
> > >   esx: switch VIR_FREE->g_free when the pointer will immediately go out
> > >     of scope
> > >   esx: eliminate unnecessary cleanup: labels and result variables
> > >   esx: replace some VIR_FREE with g_clear_pointer(x, g_free)
> > > 
> > >  src/esx/esx_driver.c                | 189 +++++++++-------------------
> > >  src/esx/esx_network_driver.c        |   4 +-
> > >  src/esx/esx_storage_backend_iscsi.c |  16 +--
> > >  src/esx/esx_storage_backend_vmfs.c  | 150 +++++++---------------
> > >  src/esx/esx_stream.c                |  11 +-
> > >  src/esx/esx_util.c                  |  41 +++---
> > >  src/esx/esx_vi.c                    | 111 ++++++----------
> > >  src/esx/esx_vi_methods.c            |   3 +-
> > >  src/esx/esx_vi_types.c              |  18 +--
> > >  9 files changed, 179 insertions(+), 364 deletions(-)
> > 
> > This appears to have broken building with Clang on Linux:
> > 
> >  https://gitlab.com/libvirt/libvirt/-/pipelines/257175967
> > 
> > Can you please look into the issue?
> 
> It should be fixed by 1f8e6a6172f2df1c4eab1cf2a26488498947641f

So it is! Nevermind then :)

-- 
Andrea Bolognani / Red Hat / Virtualization