[PATCH 13/19] qemu: migration_cookie: Add helpers for transforming the cookie into migration params

[Jiri Denemark]

On Thu, Feb 11, 2021 at 16:37:52 +0100, Peter Krempa wrote:
> 'qemuMigrationCookieBlockDirtyBitmapsMatchDisks' maps the bitmaps from
> the migration cookie to actual disk objects definition pointers.
> 
> 'qemuMigrationCookieBlockDirtyBitmapsToParams' converts the bitmap
> definitions from the migration cookie into parameters for the
> 'block-bitmap-mapping' migration parameter.
> 
> Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> ---
>  src/qemu/qemu_migration_cookie.c | 115 +++++++++++++++++++++++++++++++
>  src/qemu/qemu_migration_cookie.h |   7 ++
>  2 files changed, 122 insertions(+)
...
> diff --git a/src/qemu/qemu_migration_cookie.h b/src/qemu/qemu_migration_cookie.h
> index 8636f955da..f8393e0ce0 100644
> --- a/src/qemu/qemu_migration_cookie.h
> +++ b/src/qemu/qemu_migration_cookie.h
> @@ -226,3 +226,10 @@ qemuMigrationCookieXMLFormat(virQEMUDriverPtr driver,
>                               virQEMUCapsPtr qemuCaps,
>                               virBufferPtr buf,
>                               qemuMigrationCookiePtr mig);
> +
> +int qemuMigrationCookieBlockDirtyBitmapsMatchDisks(virDomainDefPtr def,
> +                                                   GSList *disks);
> +
> +int
> +qemuMigrationCookieBlockDirtyBitmapsToParams(GSList *disks,
> +                                             virJSONValuePtr *mapping);

A little bit of consistency would not hurt :-) Either

    int
    qemuMigrationCookieBlockDirtyBitmapsMatchDisks(...

or

    int qemuMigrationCookieBlockDirtyBitmapsToParams(...


Reviewed-by: Jiri Denemark <jdenemar at redhat.com>