[PATCH v2] qemu: Fix libvirt hang due to early TPM device stop

[Michal Privoznik]

On 2/19/21 4:57 PM, Stefan Berger wrote:
> This patch partially reverts commit 5cde9dee where the qemuExtDevicesStop()
> was moved to a location before the QEMU process is stopped. It may be
> alright to tear down some devices before QEMU is stopped, but it doesn't work
> for the external TPM (swtpm) which assumes that QEMU sends it a signal to stop
> it before libvirt may try to clean it up. So this patch moves the
> virFileDeleteTree() calls after the call to qemuExtDevicesStop() so that the
> pid file of virtiofsd is not deleted before that call.
> 
> Afftected libvirt versions are 6.10 and 7.0.
> 
> Fixes: 5cde9dee8c70b17c458d031ab6cf71dce476eea2
> Cc: Masayoshi Mizuma <m.mizuma at jp.fujitsu.com>
> Signed-off-by: Stefan Berger <stefanb at linux.ibm.com>
> ---
>   src/qemu/qemu_process.c | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)

Reviewed-by: Michal Privoznik <mprivozn at redhat.com>

and pushed.

Michal