[PATCH 01/14] ui, monitor: remove deprecated VNC ACL option and HMP commands

Thomas Huth thuth at redhat.com
Wed Feb 24 13:36:46 UTC 2021


On 24/02/2021 14.11, Daniel P. Berrangé wrote:
> The VNC ACL concept has been replaced by the pluggable "authz" framework
> which does not use monitor commands.
> 
> Reviewed-by: Dr. David Alan Gilbert <dgilbert at redhat.com>
> Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
> ---
>   docs/system/deprecated.rst       |  16 ---
>   docs/system/removed-features.rst |  13 +++
>   hmp-commands.hx                  |  76 -------------
>   monitor/misc.c                   | 187 -------------------------------
>   ui/vnc.c                         |  38 -------
>   5 files changed, 13 insertions(+), 317 deletions(-)

If I run:

  grep -r vnc.*acl *

I also see some lines in tests/check-block-qdict.c ... are they related and 
should be removed, too?

Apart from that, patch looks fine to me:
Reviewed-by: Thomas Huth <thuth at redhat.com>




More information about the libvir-list mailing list