[PATCH 06/33] virCPUx86DataParse: Don't check error from x86FeatureNames

Peter Krempa pkrempa at redhat.com
Wed Feb 24 16:16:41 UTC 2021


x86FeatureNames uses virBuffer and thus can't fail nowadays.

Signed-off-by: Peter Krempa <pkrempa at redhat.com>
---
 src/cpu/cpu_x86.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c
index 92f945beb4..79c5868ae6 100644
--- a/src/cpu/cpu_x86.c
+++ b/src/cpu/cpu_x86.c
@@ -1856,11 +1856,7 @@ virCPUx86DataParse(xmlXPathContextPtr ctxt)
  */
 #define virX86CpuIncompatible(MSG, CPU_DEF) \
         do { \
-            g_autofree char *flagsStr = NULL; \
-            if (!(flagsStr = x86FeatureNames(map, ", ", (CPU_DEF)))) { \
-                virReportOOMError(); \
-                return VIR_CPU_COMPARE_ERROR; \
-            } \
+            g_autofree char *flagsStr = x86FeatureNames(map, ", ", (CPU_DEF)); \
             if (message) \
                 *message = g_strdup_printf("%s: %s", _(MSG), flagsStr); \
             VIR_DEBUG("%s: %s", MSG, flagsStr); \
-- 
2.29.2




More information about the libvir-list mailing list