[PATCH 2/7] util: Added nfs params to virStorageSource

[Peter Krempa]

On Tue, Dec 29, 2020 at 15:21:24 -0600, Ryan Gahagan wrote:
> Signed-off-by: Ryan Gahagan <rgahagan at cs.utexas.edu>
> ---
>  src/util/virstoragefile.c | 8 ++++++++
>  src/util/virstoragefile.h | 5 +++++
>  2 files changed, 13 insertions(+)

[...]

> diff --git a/src/util/virstoragefile.h b/src/util/virstoragefile.h
> index c5d5f0233a..64fc519f87 100644
> --- a/src/util/virstoragefile.h
> +++ b/src/util/virstoragefile.h
> @@ -385,6 +385,11 @@ struct _virStorageSource {
>      /* these must not be used apart from formatting the output JSON in the qemu driver */
>      char *ssh_user;
>      bool ssh_host_key_check_disabled;
> +
> +    char *nfs_user;
> +    char *nfs_group;
> +    uid_t nfs_uid;
> +    gid_t nfs_gid;

Please add comments for nfs_uid and nfs_gid which state that the
variables hold the converted/looked up uid/gid which is used at runtinme
. This will help any further reader of the code see what they are used
for and that they are not actually based on the configuration but are
rather runtime (such as when we'll be adding driver-specific private
data for virStorageSource).