[libvirt PATCH 08/17] virstoragefile: move virStorageFileIsClusterFS into virfile

Peter Krempa pkrempa at redhat.com
Mon Jan 4 15:42:21 UTC 2021


On Mon, Dec 14, 2020 at 16:55:28 +0100, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
> ---
>  src/libvirt_private.syms  |  2 +-
>  src/qemu/qemu_migration.c |  2 +-
>  src/util/virfile.c        | 12 ++++++++++++
>  src/util/virfile.h        |  1 +
>  src/util/virstoragefile.c | 11 -----------
>  src/util/virstoragefile.h |  1 -
>  6 files changed, 15 insertions(+), 14 deletions(-)

[...]

> diff --git a/src/util/virfile.c b/src/util/virfile.c
> index 6e16780e30..3f58b98248 100644
> --- a/src/util/virfile.c
> +++ b/src/util/virfile.c
> @@ -3709,6 +3709,18 @@ int virFileIsSharedFS(const char *path)
>  }
>  
>  
> +int virFileIsClusterFS(const char *path)

Please use the modern function header format.

> +{
> +    /* These are coherent cluster filesystems known to be safe for
> +     * migration with cache != none
> +     */
> +    return virFileIsSharedFSType(path,
> +                                 VIR_FILE_SHFS_GFS2 |
> +                                 VIR_FILE_SHFS_OCFS |
> +                                 VIR_FILE_SHFS_CEPH);
> +}
> +
> +
>  #if defined(__linux__) && defined(WITH_SYS_MOUNT_H)
>  int
>  virFileSetupDev(const char *path,

Reviewed-by: Peter Krempa <pkrempa at redhat.com>




More information about the libvir-list mailing list