[PATCH 3/5] qemu: Fix retval if ACL check fails in qemuNodeGetSecurityModel
Michal Privoznik
mprivozn at redhat.com
Mon Jan 4 18:20:43 UTC 2021
While previously we returned 0 this is not correct. We have to
return a negative value to indicate error.
Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
---
src/qemu/qemu_driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 96ec84bd1c..88324945ef 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -5935,7 +5935,7 @@ static int qemuNodeGetSecurityModel(virConnectPtr conn,
memset(secmodel, 0, sizeof(*secmodel));
if (virNodeGetSecurityModelEnsureACL(conn) < 0)
- return 0;
+ return -1;
/* We treat no driver as success, but simply return no data in *secmodel */
if (!(caps = virQEMUDriverGetCapabilities(driver, false)) ||
--
2.26.2
More information about the libvir-list
mailing list