[PATCH] virsh-domain: Add quotes around '%s' formatting domain name

Michal Privoznik mprivozn at redhat.com
Tue Jan 5 12:47:31 UTC 2021


On 1/5/21 1:18 PM, Peter Krempa wrote:
> Domain name can contain spaces in which case it's not immediately clear
> from virsh messages where the boundary of the name is. Enclose all %s
> formatters in apostrophes as delimiters.
> 
> Done via the following vim regex:
> 
>   %s/omain %s/omain '%s'/g
> 
> This patch changes:
> 
>   $ virsh undefine --snapshots-metadata 'OWASP Broken Web Apps VM v1.2'
>   Domain OWASP Broken Web Apps VM v1.2 has been undefined
> 
> to:
> 
>   $ virsh undefine --snapshots-metadata 'OWASP Broken Web Apps VM v1.2'
>   Domain 'OWASP Broken Web Apps VM v1.2' has been undefined
> 
> Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> ---
>   tests/virsh-define-dev-segfault |   2 +-
>   tests/virsh-read-bufsiz         |   2 +-
>   tests/virsh-undefine            |   8 +-
>   tools/virsh-domain.c            | 136 ++++++++++++++++----------------
>   4 files changed, 74 insertions(+), 74 deletions(-)

Reviewed-by: Michal Privoznik <mprivozn at redhat.com>

Michal




More information about the libvir-list mailing list