[PATCH 1/3] virStorageBackendCopyToFD: remove unused return variable

Michal Privoznik mprivozn at redhat.com
Tue Jan 5 13:11:58 UTC 2021


On 12/29/20 12:29 PM, Yi Li wrote:
> remove unused return variable,
> The errno will throw by virReportSystemError
> 
> Signed-off-by: Yi Li <yili at winhong.com>
> ---
>   src/storage/storage_util.c | 22 +++++++---------------
>   1 file changed, 7 insertions(+), 15 deletions(-)


Patches look good, but I'd reorder them a bit. 2/3 should go first, then 
this on and 3/3 the last. Also, can you please send v2 with cover 
letter? It's easy as 'git format-patch -v2 --cover-letter ...'

Michal




More information about the libvir-list mailing list