[PATCH] qemu: backup: Properly delete temporary bitmap after push-mode incremental backup

Peter Krempa pkrempa at redhat.com
Tue Jan 5 14:49:00 UTC 2021

Refactor in 0316c28a453ac used incorrect source variable to initialize
the variable which holds the name of the bitmap which needs to be
deleted after the backup job finishes. This resulted into deleting the
source bitmap of the backup rather than the temporary one.

Use 'dd->incrementalBitmap' which holds the temporary bitmap name
instead of 'dd->backupdisk->incremental' which holds the name of the
source bitmap which is used by the backup.

Fixes: 0316c28a453ac15f58c61f30359f66ab9a649884
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1908647
Signed-off-by: Peter Krempa <pkrempa at redhat.com>
 src/qemu/qemu_backup.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/qemu/qemu_backup.c b/src/qemu/qemu_backup.c
index b2340eb1cf..c444f8aaba 100644
--- a/src/qemu/qemu_backup.c
+++ b/src/qemu/qemu_backup.c
@@ -235,7 +235,7 @@ qemuBackupDiskPrepareOneBitmaps(struct qemuBackupDiskData *dd,
                                                  blockNamedNodeData) < 0)
             return -1;

-        dd->domdiskIncrementalBitmap = dd->backupdisk->incremental;
+        dd->domdiskIncrementalBitmap = dd->incrementalBitmap;

     return 0;

More information about the libvir-list mailing list