[libvirt PATCH v3 13/21] virsh: Add --active, --inactive, --all to nodedev-list

[Erik Skultety]

On Thu, Dec 24, 2020 at 08:14:37AM -0600, Jonathon Jongsma wrote:
> Now that we can filter active and inactive node devices in
> virConnectListAllNodeDevices(), add these switches to the virsh command.
> 
> Eventual output (once everything is hooked up):
> 
>     virsh # nodedev-list --inactive --cap mdev
>     mdev_07d8b8b0_7e04_4c0f_97ed_9214ce12723c
>     mdev_927c040f_ae7d_4a35_966e_286ba6ebbe1c
> 
>     virsh # nodedev-list --active --cap mdev
>     mdev_bd2ea955_3402_4252_8c17_7468083a0f26

This patch doesn't introduce --active (which is correct), so both the subject
and the commit message need to be adjusted.

>  
> +    if (all && inactive) {
> +        vshError(ctl, "%s", _("Option --all is incompatible with --inactive"));
> +        return false;
> +    }
> +
> +    if (tree && (cap_str || inactive)) {

we should also check for 'all', since --tree is exclusive with everything else.

Reviewed-by: Erik Skultety <eskultet at redhat.com>