[PATCH RFC 1/2] qemu: use "-accel" option to specify accelerator instead of "-machine"

[Bruce Rogers]

On Mon, 2021-01-11 at 10:51 +0100, Paolo Bonzini wrote:
> On 11/01/21 10:38, Daniel P. Berrangé wrote:
> > > 
> > > The "-machine" options for accelerators are legacy, the "-accel"
> > > options
> > > is a better mechanism. The following are the details:
> > > https://lore.kernel.org/qemu-devel/3aa73987-40e8-3619-0723-9f17f73850bd@redhat.com/
> > > 
> > > This patch switch the option "-machine accel=xxx" to "-accel xxx"
> > > when
> > > specifying accelerator type once libvirt build QEMU command line.
> > This is going to break use of the /usr/bin/qemu-kvm wrapper on
> > Fedora because QEMU refuses to allow -accel combined with -machine
> > 
> > $ /usr/bin/qemu-kvm -accel tc
> > qemu-system-x86_64: The -accel and "-machine accel=" options are
> > incompatible
> 
> That script is useless, a symlink will do ever since QEMU 4.0. 
> Fedora 
> can and should get rid of it, I'll take a look.
> 
> Is there any other distro that does the same?  Libvirt cannot use
> newer 
> KVM features with "-machine accel".
> 
> Paolo
> 

openSUSE / SUSE does this as well in the legacy qemu-kvm package. We'll
look into doing this instead via a symlink. Thanks for the heads up on
this issue.

- Bruce