[libvirt PATCH v2 2/3] gitlab-ci.yml: Convert only/except to the rules syntax

[Andrea Bolognani]

On Thu, 2021-01-14 at 12:54 +0100, Erik Skultety wrote:
> On Thu, Jan 14, 2021 at 12:45:40PM +0100, Andrea Bolognani wrote:
> > On Thu, 2021-01-14 at 12:03 +0100, Erik Skultety wrote:
> > >  .native_build_job_template:
> > >    stage: builds
> > >    image: $CI_REGISTRY_IMAGE/ci-$NAME:latest
> > > +  rules:
> > > +    - when: on_success
> > 
> > According to
> > 
> >   https://docs.gitlab.com/ee/ci/yaml/#when
> > 
> > when:on_success is the default, so I don't see the reason to have a
> > rules: section in this case. More instances of this further down.
> 
> I'm adding the rule in the next patch, I didn't want to put it in the next
> though to prevent potential confusion. In this patch it's a NOP, in the next
> one it will matter though, because if no rule matches the default action is
> that the job is not going to be added to the pipeline, so you need a top level
> 'when' to make sure that if no rule matches the job is still selected for the
> pipeline.

Oh, I missed this detail! Having when:on_success makes sense then.

-- 
Andrea Bolognani / Red Hat / Virtualization