[PATCH 1/6] qemu_capabilities: Introduce QEMU_CAPS_DEVICE_VIRTIO_PMEM_PCI

[Daniel Henrique Barboza]

On 1/15/21 11:12 AM, Michal Privoznik wrote:
> In this commit a new capability is introduced that reflect device
> support by given qemu:

This sounds a bit strange to me. What about this:

"This commit introduces a new capability that reflects virtio-pmem-pci
device support in qemu:"


> 
>    QEMU_CAPS_DEVICE_VIRTIO_PMEM_PCI, /* -device virtio-pmem-pci */
> 
> The virtio-pmem-pci device was introduced in QEMU 4.1.
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---

Reviewed-by: Daniel Henrique Barboza <danielhb413 at gmail.com>


>   src/qemu/qemu_capabilities.c                     | 2 ++
>   src/qemu/qemu_capabilities.h                     | 1 +
>   tests/qemucapabilitiesdata/caps_4.1.0.x86_64.xml | 1 +
>   tests/qemucapabilitiesdata/caps_4.2.0.x86_64.xml | 1 +
>   tests/qemucapabilitiesdata/caps_5.0.0.x86_64.xml | 1 +
>   tests/qemucapabilitiesdata/caps_5.1.0.x86_64.xml | 1 +
>   tests/qemucapabilitiesdata/caps_5.2.0.x86_64.xml | 1 +
>   7 files changed, 8 insertions(+)
> 
> diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
> index 4d132defbd..d656732c3e 100644
> --- a/src/qemu/qemu_capabilities.c
> +++ b/src/qemu/qemu_capabilities.c
> @@ -609,6 +609,7 @@ VIR_ENUM_IMPL(virQEMUCaps,
>                 "ncr53c90",
>                 "dc390",
>                 "am53c974",
> +              "virtio-pmem-pci",
>       );
>   
>   
> @@ -1325,6 +1326,7 @@ struct virQEMUCapsStringFlags virQEMUCapsObjectTypes[] = {
>        */
>       { "dc390", QEMU_CAPS_SCSI_DC390 },
>       { "am53c974", QEMU_CAPS_SCSI_AM53C974 },
> +    { "virtio-pmem-pci", QEMU_CAPS_DEVICE_VIRTIO_PMEM_PCI },
>   };
>   
>   
> diff --git a/src/qemu/qemu_capabilities.h b/src/qemu/qemu_capabilities.h
> index 0f90efa459..a14a78f959 100644
> --- a/src/qemu/qemu_capabilities.h
> +++ b/src/qemu/qemu_capabilities.h
> @@ -589,6 +589,7 @@ typedef enum { /* virQEMUCapsFlags grouping marker for syntax-check */
>       QEMU_CAPS_SCSI_NCR53C90, /* built-in SCSI */
>       QEMU_CAPS_SCSI_DC390, /* -device dc-390 */
>       QEMU_CAPS_SCSI_AM53C974, /* -device am53c974 */
> +    QEMU_CAPS_DEVICE_VIRTIO_PMEM_PCI, /* -device virtio-pmem-pci */
>   
>       QEMU_CAPS_LAST /* this must always be the last item */
>   } virQEMUCapsFlags;
> diff --git a/tests/qemucapabilitiesdata/caps_4.1.0.x86_64.xml b/tests/qemucapabilitiesdata/caps_4.1.0.x86_64.xml
> index 58774fddcc..28a4b0ede0 100644
> --- a/tests/qemucapabilitiesdata/caps_4.1.0.x86_64.xml
> +++ b/tests/qemucapabilitiesdata/caps_4.1.0.x86_64.xml
> @@ -231,6 +231,7 @@
>     <flag name='fsdev.createmode'/>
>     <flag name='dc390'/>
>     <flag name='am53c974'/>
> +  <flag name='virtio-pmem-pci'/>
>     <version>4001000</version>
>     <kvmVersion>0</kvmVersion>
>     <microcodeVersion>43100241</microcodeVersion>
> diff --git a/tests/qemucapabilitiesdata/caps_4.2.0.x86_64.xml b/tests/qemucapabilitiesdata/caps_4.2.0.x86_64.xml
> index 1ba8c09374..e150741f11 100644
> --- a/tests/qemucapabilitiesdata/caps_4.2.0.x86_64.xml
> +++ b/tests/qemucapabilitiesdata/caps_4.2.0.x86_64.xml
> @@ -240,6 +240,7 @@
>     <flag name='fsdev.createmode'/>
>     <flag name='dc390'/>
>     <flag name='am53c974'/>
> +  <flag name='virtio-pmem-pci'/>
>     <version>4002000</version>
>     <kvmVersion>0</kvmVersion>
>     <microcodeVersion>43100242</microcodeVersion>
> diff --git a/tests/qemucapabilitiesdata/caps_5.0.0.x86_64.xml b/tests/qemucapabilitiesdata/caps_5.0.0.x86_64.xml
> index 849727eb40..7c56d110f4 100644
> --- a/tests/qemucapabilitiesdata/caps_5.0.0.x86_64.xml
> +++ b/tests/qemucapabilitiesdata/caps_5.0.0.x86_64.xml
> @@ -247,6 +247,7 @@
>     <flag name='fsdev.createmode'/>
>     <flag name='dc390'/>
>     <flag name='am53c974'/>
> +  <flag name='virtio-pmem-pci'/>
>     <version>5000000</version>
>     <kvmVersion>0</kvmVersion>
>     <microcodeVersion>43100241</microcodeVersion>
> diff --git a/tests/qemucapabilitiesdata/caps_5.1.0.x86_64.xml b/tests/qemucapabilitiesdata/caps_5.1.0.x86_64.xml
> index ff5f42a563..07466093c9 100644
> --- a/tests/qemucapabilitiesdata/caps_5.1.0.x86_64.xml
> +++ b/tests/qemucapabilitiesdata/caps_5.1.0.x86_64.xml
> @@ -249,6 +249,7 @@
>     <flag name='fsdev.createmode'/>
>     <flag name='dc390'/>
>     <flag name='am53c974'/>
> +  <flag name='virtio-pmem-pci'/>
>     <version>5001000</version>
>     <kvmVersion>0</kvmVersion>
>     <microcodeVersion>43100242</microcodeVersion>
> diff --git a/tests/qemucapabilitiesdata/caps_5.2.0.x86_64.xml b/tests/qemucapabilitiesdata/caps_5.2.0.x86_64.xml
> index cebacc249d..dea2ff4b54 100644
> --- a/tests/qemucapabilitiesdata/caps_5.2.0.x86_64.xml
> +++ b/tests/qemucapabilitiesdata/caps_5.2.0.x86_64.xml
> @@ -250,6 +250,7 @@
>     <flag name='fsdev.createmode'/>
>     <flag name='dc390'/>
>     <flag name='am53c974'/>
> +  <flag name='virtio-pmem-pci'/>
>     <version>5002000</version>
>     <kvmVersion>0</kvmVersion>
>     <microcodeVersion>43100243</microcodeVersion>
>