[libvirt PATCH 0/8] Remove space-padded alignment from public headers
jjongsma at redhat.com
Thu Jan 21 15:49:37 UTC 2021
On Thu, 21 Jan 2021 08:38:06 +0100
Erik Skultety <eskultet at redhat.com> wrote:
> On Wed, Jan 20, 2021 at 11:33:41AM -0600, Jonathon Jongsma wrote:
> > Erik Skultety suggested posting a separate series removing the
> > space-padded alignment of function declarations in the public
> > headers.
> This is already an improvement. We've gradually adopted a style where
> function declarations are separated by a single empty line and
> definitions by 2 (although, as with anything we're not 100%
> consistent all the time). With that said, we haven't converted the
> headers to follow this style yet (I remember John Ferlan did this
> conversion for most of the sources in the past).
> Now, it depends whether you want to waste a few more minutes on
> fixing the style in headers or not, I'm okay both ways - if you think
> it's a waste of your time, just let me know and we'll create another
> warmup bitesized task for libvirt newcomers.
> Regardless of how you decide about the code style:
> Reviewed-by: Erik Skultety <eskultet at redhat.com>
> (I'll fix the nit if you're done with this series)
It shouldn't take much time. I'll try to go through and revise it.
More information about the libvir-list