[libvirt PATCH v2 08/13] util: move virStorageFileBackend code into storage_file

Pavel Hrdina phrdina at redhat.com
Thu Jan 21 19:34:22 UTC 2021


It's used only by storage file code so it doesn't make sense to have
it in util directory.

Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
---
 po/POTFILES.in                                            | 2 +-
 src/libvirt_private.syms                                  | 8 ++++----
 src/storage_file/meson.build                              | 1 +
 .../storage_file_backend.c}                               | 4 ++--
 .../storage_file_backend.h}                               | 2 +-
 src/storage_file/storage_file_fs.c                        | 2 +-
 src/storage_file/storage_file_gluster.c                   | 2 +-
 src/storage_file/storage_source.c                         | 2 +-
 src/util/meson.build                                      | 1 -
 9 files changed, 12 insertions(+), 12 deletions(-)
 rename src/{util/virstoragefilebackend.c => storage_file/storage_file_backend.c} (97%)
 rename src/{util/virstoragefilebackend.h => storage_file/storage_file_backend.h} (97%)

diff --git a/po/POTFILES.in b/po/POTFILES.in
index 1e47af987d..4da22ede8f 100644
--- a/po/POTFILES.in
+++ b/po/POTFILES.in
@@ -223,6 +223,7 @@
 @SRCDIR at src/storage/storage_backend_zfs.c
 @SRCDIR at src/storage/storage_driver.c
 @SRCDIR at src/storage/storage_util.c
+ at SRCDIR@src/storage_file/storage_file_backend.c
 @SRCDIR at src/storage_file/storage_file_fs.c
 @SRCDIR at src/storage_file/storage_file_gluster.c
 @SRCDIR at src/storage_file/storage_source.c
@@ -306,7 +307,6 @@
 @SRCDIR at src/util/virsocketaddr.c
 @SRCDIR at src/util/virstorageencryption.c
 @SRCDIR at src/util/virstoragefile.c
- at SRCDIR@src/util/virstoragefilebackend.c
 @SRCDIR at src/util/virstoragefileprobe.c
 @SRCDIR at src/util/virstring.c
 @SRCDIR at src/util/virsysinfo.c
diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
index 67a863467d..e7af8f0599 100644
--- a/src/libvirt_private.syms
+++ b/src/libvirt_private.syms
@@ -1618,6 +1618,10 @@ virSecurityManagerVerify;
 virSecurityXATTRNamespaceDefined;
 
 
+# storage_file/storage_file_backend.h
+virStorageFileBackendRegister;
+
+
 # storage_file/storage_source.h
 virStorageFileAccess;
 virStorageFileChainLookup;
@@ -3210,10 +3214,6 @@ virStorageTypeFromString;
 virStorageTypeToString;
 
 
-# util/virstoragefilebackend.h
-virStorageFileBackendRegister;
-
-
 # util/virstoragefileprobe.h
 virStorageFileProbeFormat;
 virStorageFileProbeGetMetadata;
diff --git a/src/storage_file/meson.build b/src/storage_file/meson.build
index bae018feac..bcd6f01906 100644
--- a/src/storage_file/meson.build
+++ b/src/storage_file/meson.build
@@ -1,5 +1,6 @@
 storage_file_sources = [
   'storage_source.c',
+  'storage_file_backend.c',
 ]
 
 stoarge_file_fs_sources = [
diff --git a/src/util/virstoragefilebackend.c b/src/storage_file/storage_file_backend.c
similarity index 97%
rename from src/util/virstoragefilebackend.c
rename to src/storage_file/storage_file_backend.c
index 55c62b0212..6e4b2f408b 100644
--- a/src/util/virstoragefilebackend.c
+++ b/src/storage_file/storage_file_backend.c
@@ -1,5 +1,5 @@
 /*
- * virstoragefilebackend.c: internal storage source backend contract
+ * storage_file_backend.c: internal storage source backend contract
  *
  * Copyright (C) 2007-2018 Red Hat, Inc.
  * Copyright (C) 2007-2008 Daniel P. Berrange
@@ -27,7 +27,7 @@
 #include "virerror.h"
 #include "viralloc.h"
 #include "internal.h"
-#include "virstoragefilebackend.h"
+#include "storage_file_backend.h"
 #include "virlog.h"
 #include "virmodule.h"
 #include "virfile.h"
diff --git a/src/util/virstoragefilebackend.h b/src/storage_file/storage_file_backend.h
similarity index 97%
rename from src/util/virstoragefilebackend.h
rename to src/storage_file/storage_file_backend.h
index 43b36e95bc..ad0f66212c 100644
--- a/src/util/virstoragefilebackend.h
+++ b/src/storage_file/storage_file_backend.h
@@ -1,5 +1,5 @@
 /*
- * virstoragefilebackend.h: internal storage source backend contract
+ * storage_file_backend.h: internal storage source backend contract
  *
  * Copyright (C) 2007-2018 Red Hat, Inc.
  *
diff --git a/src/storage_file/storage_file_fs.c b/src/storage_file/storage_file_fs.c
index 5a44ef8c2d..1cc9233512 100644
--- a/src/storage_file/storage_file_fs.c
+++ b/src/storage_file/storage_file_fs.c
@@ -25,9 +25,9 @@
 #include <fcntl.h>
 
 #include "virerror.h"
+#include "storage_file_backend.h"
 #include "storage_file_fs.h"
 #include "storage_util.h"
-#include "virstoragefilebackend.h"
 #include "vircommand.h"
 #include "viralloc.h"
 #include "virfile.h"
diff --git a/src/storage_file/storage_file_gluster.c b/src/storage_file/storage_file_gluster.c
index 2560e10d37..0828088c2c 100644
--- a/src/storage_file/storage_file_gluster.c
+++ b/src/storage_file/storage_file_gluster.c
@@ -23,12 +23,12 @@
 
 #include <glusterfs/api/glfs.h>
 
+#include "storage_file_backend.h"
 #include "storage_file_gluster.h"
 #include "viralloc.h"
 #include "virerror.h"
 #include "virlog.h"
 #include "virstoragefile.h"
-#include "virstoragefilebackend.h"
 #include "virstring.h"
 
 #define VIR_FROM_THIS VIR_FROM_STORAGE
diff --git a/src/storage_file/storage_source.c b/src/storage_file/storage_source.c
index b5e0bc5040..744d3e94fd 100644
--- a/src/storage_file/storage_source.c
+++ b/src/storage_file/storage_source.c
@@ -25,6 +25,7 @@
 #include <unistd.h>
 
 #include "internal.h"
+#include "storage_file_backend.h"
 #include "storage_source.h"
 #include "viralloc.h"
 #include "virerror.h"
@@ -34,7 +35,6 @@
 #include "virlog.h"
 #include "virobject.h"
 #include "virstoragefile.h"
-#include "virstoragefilebackend.h"
 #include "virstoragefileprobe.h"
 #include "virstring.h"
 #include "viruri.h"
diff --git a/src/util/meson.build b/src/util/meson.build
index 9fb270fadd..64c0f9df6d 100644
--- a/src/util/meson.build
+++ b/src/util/meson.build
@@ -90,7 +90,6 @@ util_sources = [
   'virsocketaddr.c',
   'virstorageencryption.c',
   'virstoragefile.c',
-  'virstoragefilebackend.c',
   'virstoragefileprobe.c',
   'virstring.c',
   'virsysinfo.c',
-- 
2.29.2




More information about the libvir-list mailing list