[libvirt PATCH v2 11/13] util: move virStorageEncryption code into conf

Pavel Hrdina phrdina at redhat.com
Thu Jan 21 19:34:25 UTC 2021


The code handles XML bits and internal definition and should be
in conf directory.

Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
---
 po/POTFILES.in                                       |  2 +-
 src/conf/domain_conf.h                               |  2 +-
 src/conf/meson.build                                 |  1 +
 src/conf/storage_conf.h                              |  2 +-
 .../storage_encryption_conf.c}                       |  4 ++--
 .../storage_encryption_conf.h}                       |  2 +-
 src/conf/storage_source_conf.h                       |  2 +-
 src/libvirt_private.syms                             | 12 ++++++------
 src/util/meson.build                                 |  1 -
 9 files changed, 14 insertions(+), 14 deletions(-)
 rename src/{util/virstorageencryption.c => conf/storage_encryption_conf.c} (99%)
 rename src/{util/virstorageencryption.h => conf/storage_encryption_conf.h} (98%)

diff --git a/po/POTFILES.in b/po/POTFILES.in
index 00100d7d73..05bbe21462 100644
--- a/po/POTFILES.in
+++ b/po/POTFILES.in
@@ -43,6 +43,7 @@
 @SRCDIR at src/conf/snapshot_conf.c
 @SRCDIR at src/conf/storage_adapter_conf.c
 @SRCDIR at src/conf/storage_conf.c
+ at SRCDIR@src/conf/storage_encryption_conf.c
 @SRCDIR at src/conf/storage_source_conf.c
 @SRCDIR at src/conf/virchrdev.c
 @SRCDIR at src/conf/virdomainmomentobjlist.c
@@ -307,7 +308,6 @@
 @SRCDIR at src/util/virscsivhost.c
 @SRCDIR at src/util/virsecret.c
 @SRCDIR at src/util/virsocketaddr.c
- at SRCDIR@src/util/virstorageencryption.c
 @SRCDIR at src/util/virstoragefile.c
 @SRCDIR at src/util/virstring.c
 @SRCDIR at src/util/virsysinfo.c
diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h
index f5d346ddf0..95ad052891 100644
--- a/src/conf/domain_conf.h
+++ b/src/conf/domain_conf.h
@@ -29,7 +29,7 @@
 #include "internal.h"
 #include "virconftypes.h"
 #include "capabilities.h"
-#include "virstorageencryption.h"
+#include "storage_encryption_conf.h"
 #include "cpu_conf.h"
 #include "virthread.h"
 #include "virhash.h"
diff --git a/src/conf/meson.build b/src/conf/meson.build
index 9d4831b815..bd35d87e0a 100644
--- a/src/conf/meson.build
+++ b/src/conf/meson.build
@@ -54,6 +54,7 @@ storage_conf_sources = [
   'storage_adapter_conf.c',
   'storage_capabilities.c',
   'storage_conf.c',
+  'storage_encryption_conf.c',
   'storage_source_conf.c',
   'virstorageobj.c',
 ]
diff --git a/src/conf/storage_conf.h b/src/conf/storage_conf.h
index aeda2891d4..647eb847bf 100644
--- a/src/conf/storage_conf.h
+++ b/src/conf/storage_conf.h
@@ -22,7 +22,7 @@
 #pragma once
 
 #include "internal.h"
-#include "virstorageencryption.h"
+#include "storage_encryption_conf.h"
 #include "storage_source_conf.h"
 #include "virbitmap.h"
 #include "virthread.h"
diff --git a/src/util/virstorageencryption.c b/src/conf/storage_encryption_conf.c
similarity index 99%
rename from src/util/virstorageencryption.c
rename to src/conf/storage_encryption_conf.c
index c893f0babe..34ad5dffeb 100644
--- a/src/util/virstorageencryption.c
+++ b/src/conf/storage_encryption_conf.c
@@ -1,5 +1,5 @@
 /*
- * virstorageencryption.c: volume encryption information
+ * storage_encryption_conf.c: volume encryption information
  *
  * Copyright (C) 2009-2014 Red Hat, Inc.
  *
@@ -27,7 +27,7 @@
 
 #include "virbuffer.h"
 #include "viralloc.h"
-#include "virstorageencryption.h"
+#include "storage_encryption_conf.h"
 #include "virxml.h"
 #include "virerror.h"
 #include "viruuid.h"
diff --git a/src/util/virstorageencryption.h b/src/conf/storage_encryption_conf.h
similarity index 98%
rename from src/util/virstorageencryption.h
rename to src/conf/storage_encryption_conf.h
index 352dd373d6..0799421763 100644
--- a/src/util/virstorageencryption.h
+++ b/src/conf/storage_encryption_conf.h
@@ -1,5 +1,5 @@
 /*
- * virstorageencryption.h: volume encryption information
+ * storage_encryption_conf.h: volume encryption information
  *
  * Copyright (C) 2009-2011, 2014 Red Hat, Inc.
  *
diff --git a/src/conf/storage_source_conf.h b/src/conf/storage_source_conf.h
index 6f39ab4bd0..e66ccdedef 100644
--- a/src/conf/storage_source_conf.h
+++ b/src/conf/storage_source_conf.h
@@ -21,13 +21,13 @@
 
 #pragma once
 
+#include "storage_encryption_conf.h"
 #include "virbitmap.h"
 #include "virenum.h"
 #include "virobject.h"
 #include "virpci.h"
 #include "virseclabel.h"
 #include "virsecret.h"
-#include "virstorageencryption.h"
 
 /* Types of disk backends (host resource).  Comparable to the public
  * virStorageVolType, except we have an undetermined state, don't have
diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
index b13d0db209..e8fe8e6c12 100644
--- a/src/libvirt_private.syms
+++ b/src/libvirt_private.syms
@@ -1047,6 +1047,12 @@ virStorageVolTypeFromString;
 virStorageVolTypeToString;
 
 
+# conf/storage_encryption_conf.h
+virStorageEncryptionFormat;
+virStorageEncryptionFree;
+virStorageEncryptionParseNode;
+
+
 # conf/storage_event.h
 virStoragePoolEventLifecycleNew;
 virStoragePoolEventRefreshNew;
@@ -3206,12 +3212,6 @@ virSocketAddrSetIPv6AddrNetOrder;
 virSocketAddrSetPort;
 
 
-# util/virstorageencryption.h
-virStorageEncryptionFormat;
-virStorageEncryptionFree;
-virStorageEncryptionParseNode;
-
-
 # util/virstoragefile.h
 virStorageFileCanonicalizePath;
 virStorageFileGetNPIVKey;
diff --git a/src/util/meson.build b/src/util/meson.build
index b510f0ebe9..c077c5cc99 100644
--- a/src/util/meson.build
+++ b/src/util/meson.build
@@ -88,7 +88,6 @@ util_sources = [
   'virsecret.c',
   'virsocket.c',
   'virsocketaddr.c',
-  'virstorageencryption.c',
   'virstoragefile.c',
   'virstring.c',
   'virsysinfo.c',
-- 
2.29.2




More information about the libvir-list mailing list