[PATCH 3/3] rpm: disable netcf for the interface driver on RHEL/Fedora/CentOS

Laine Stump laine at redhat.com
Fri Jan 22 08:01:57 UTC 2021

Since libvirt.spec explicitly adds -Dnetcf=enabled to the meson
commandline, just setting the default in the meson.build file won't
have any effect for rpm builds. This patch changes the meson
commandline in the spec file to -Dnetcf=disabled and removes the
associated BuildRequires: and Requires:

(I debated whether or not to do that conditionally only for (fedora >
33 || rhel > 8) but haven't done that for now (still may if it's
considered important; for Fedora probably not important (since we
never rebase after release), for RHEL we might want to preserve
current behavior for RHEL8 even through a rebase though)

Signed-off-by: Laine Stump <laine at redhat.com>
 libvirt.spec.in | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/libvirt.spec.in b/libvirt.spec.in
index b5892987cf..ec82839e10 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -359,7 +359,6 @@ BuildRequires: fuse-devel >= 2.8.6
 BuildRequires: libssh2-devel >= 1.3.0
-BuildRequires: netcf-devel >= 0.2.2
 %if %{with_esx}
 BuildRequires: libcurl-devel
@@ -528,13 +527,10 @@ capabilities.
 Summary: Interface driver plugin for the libvirtd daemon
 Requires: libvirt-daemon = %{version}-%{release}
 Requires: libvirt-libs = %{version}-%{release}
-Requires: netcf-libs >= 0.2.2
 %description daemon-driver-interface
 The interface driver plugin for the libvirtd daemon, providing
-an implementation of the network interface APIs using the
-netcf library
+an implementation of the network interface APIs using udev.
 %package daemon-driver-secret
 Summary: Secret driver plugin for the libvirtd daemon
@@ -1170,7 +1166,7 @@ export SOURCE_DATE_EPOCH=$(stat --printf='%Y' %{_specdir}/%{name}.spec)
            %{?arg_numad} \
            -Dcapng=enabled \
            %{?arg_fuse} \
-           -Dnetcf=enabled \
+           -Dnetcf=disabled \
            -Dselinux=enabled \
            %{?arg_selinux_mount} \
            -Dapparmor=disabled \

More information about the libvir-list mailing list