[libvirt PATCH v2 08/13] util: move virStorageFileBackend code into storage_file

[Peter Krempa]

On Fri, Jan 22, 2021 at 10:13:02 +0100, Pavel Hrdina wrote:
> On Fri, Jan 22, 2021 at 09:54:06AM +0100, Peter Krempa wrote:
> > On Thu, Jan 21, 2021 at 20:34:22 +0100, Pavel Hrdina wrote:
> > > It's used only by storage file code so it doesn't make sense to have
> > > it in util directory.
> > > 
> > > Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
> > > ---
> > >  po/POTFILES.in                                            | 2 +-
> > >  src/libvirt_private.syms                                  | 8 ++++----
> > >  src/storage_file/meson.build                              | 1 +
> > >  .../storage_file_backend.c}                               | 4 ++--
> > >  .../storage_file_backend.h}                               | 2 +-
> > >  src/storage_file/storage_file_fs.c                        | 2 +-
> > >  src/storage_file/storage_file_gluster.c                   | 2 +-
> > >  src/storage_file/storage_source.c                         | 2 +-
> > >  src/util/meson.build                                      | 1 -
> > >  9 files changed, 12 insertions(+), 12 deletions(-)
> > >  rename src/{util/virstoragefilebackend.c => storage_file/storage_file_backend.c} (97%)
> > >  rename src/{util/virstoragefilebackend.h => storage_file/storage_file_backend.h} (97%)
> > 
> > Reviewed-by: Peter Krempa <pkrempa at redhat.com>
> > 
> > although I'm probably more inclined to keep the original name without
> > underscores and with vir prefix.
> 
> I personally don't have any preference. The only motivation was not to
> mix two different naming styles withing one directory.
> 
> We should eventually unify the file naming style across the whole
> project as we use underscores, dash and nothing all over the place.

Yes, it can be done separately.