[PATCH 3/3] rpm: disable netcf for the interface driver on RHEL/Fedora/CentOS

Laine Stump laine at redhat.com
Fri Jan 22 16:41:12 UTC 2021

On 1/22/21 4:49 AM, Daniel P. Berrangé wrote:
> On Fri, Jan 22, 2021 at 03:01:57AM -0500, Laine Stump wrote:
>> Since libvirt.spec explicitly adds -Dnetcf=enabled to the meson
>> commandline, just setting the default in the meson.build file won't
>> have any effect for rpm builds. This patch changes the meson
>> commandline in the spec file to -Dnetcf=disabled and removes the
>> associated BuildRequires: and Requires:
>> (I debated whether or not to do that conditionally only for (fedora >
>> 33 || rhel > 8) but haven't done that for now (still may if it's
>> considered important; for Fedora probably not important (since we
>> never rebase after release), for RHEL we might want to preserve
>> current behavior for RHEL8 even through a rebase though)
> Yeah, our normal policy is that we don't disable stuff that was
> already present. So changing this should be conditional on
> newer distros only.

Okay, I'll make it more elaborate (with its own variable ala 
firewalld_zones) and repost.

Speaking of this - I just noticed that Fedora will be branching for F34 
prior to the next libvirt release, and I was hoping I could get this 
into the next Fedora (wish I'd been paying closer attention to the 
important dates :-( - I really need those entered in the same calendar 
that reminds me of my doctor appointments and meetings).

More information about the libvir-list mailing list