[libvirt PATCH v2 0/2] stop using netcf for the interface driver backend

[Neal Gompa]

On Sun, Jan 24, 2021 at 1:45 AM Laine Stump <laine at redhat.com> wrote:
>
> V1 here: https://www.redhat.com/archives/libvir-list/2021-January/msg00922.html
>
> A short version of the cover letter from V1: this is a followup to my
> proposal to stop using netcf for the interface driver backend in
> Fedora/RHEL/CentOS builds and use the udev backend instead (it turns
> out Ubuntu already disabled netcf in 2018).
>
> Changes in V2:
>
> * removed the patch that made the default netcf=disabled even when
>   netcf-devel was found on the host. If someone has netcf-devel
>   installed and still wants to build without netcf, then can add
>   "-Dnetcf=disabled" on the meson commandline.
>
> * Made the specfile changes more intelligent:
>
>   * instead of hardcoding -Dnetcf=disabled, we now have a variable
>     %{with_netcf} that is set to 1 for current Fedora (< 34) and current
>     RHEL (< 9) but will be set to 0 for future Fedora/RHEL. This way the
>     behavior on current OS releases will remain the same even for future
>     libvirt.
>
>   * it is possible to for netcf support off even in current/older OS
>     releases by adding "--without netcf" to the rpmbuild commandline.
>
> I think at this point I would be comfortable pushing these patches, unless someone has misgivings about it...
>
> Laine Stump (2):
>   build: support explicitly disabling netcf
>   rpm: disable netcf for the interface driver in rpm build on new
>     targets
>
>  libvirt.spec.in | 22 +++++++++++++++++-----
>  meson.build     | 10 ++++++----
>  2 files changed, 23 insertions(+), 9 deletions(-)
>
> --
> 2.29.2
>

This looks fine to me, but I'm wondering why libvirt doesn't
communicate with NetworkManager for this information? That's a cross
distribution method of handling complex network configuration that we
basically know will exist and can handle parsing and configuring
networks effectively.

Otherwise...

Reviewed-by: Neal Gompa <ngompa13 at gmail.com>


-- 
真実はいつも一つ！/ Always, there's only one truth!