[PATCH] spec: Increase meson test timeout 10x
Michal Privoznik
mprivozn at redhat.com
Mon Jan 25 10:54:29 UTC 2021
On 1/21/21 10:55 PM, Cole Robinson wrote:
> Tests time out when building in slow environments, like emulated
> s390x in Fedora copr. Bump up the test timeout
>
> Signed-off-by: Cole Robinson <crobinso at redhat.com>
> ---
> libvirt.spec.in | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/libvirt.spec.in b/libvirt.spec.in
> index 0a8b0ebad4..1731aa8bd9 100644
> --- a/libvirt.spec.in
> +++ b/libvirt.spec.in
> @@ -1288,7 +1288,9 @@ mv $RPM_BUILD_ROOT%{_datadir}/systemtap/tapset/libvirt_qemu_probes.stp \
> %endif
>
> %check
> -VIR_TEST_DEBUG=1 %meson_test --no-suite syntax-check
> +# Building on slow archs, like emulated s390x in Fedora copr, requires
> +# raising the test timeout
> +VIR_TEST_DEBUG=1 %meson_test --no-suite syntax-check --timeout-multiplier 10
>
> %post libs
> %if 0%{?rhel} == 7
>
Looks like we have consensus here. In the past, we've increased the
timeout for qemuxml2argvtest:
https://gitlab.com/libvirt/libvirt/-/commit/94146c9d2ba
Would it make sense finally admit that not everybody is running top
shelf CPU and increase the timeout even for 'ninja test'? I mean, set
timeout to a bigger value in tests/meson.build and drop special casing
of one test?
Michal
More information about the libvir-list
mailing list