[libvirt PATCH] gitlab: force dwarf4 format for debuginfo in Fedora rawhide

[Daniel P. Berrangé]

On Tue, Jan 26, 2021 at 12:58:10PM +0100, Erik Skultety wrote:
> On Mon, Jan 25, 2021 at 06:52:12PM +0000, Daniel P. Berrangé wrote:
> > Fedora 34 rawhide has pulled in a new GCC 11 build which now
> > defaults to dwarf5 format. This format is not compatible with
> > the pdwtags program used in our test suite to validate the
> > RPC files.
> > 
> > We have no need for debuginfo in CI except for pdwtags,
> > so the simplest short term fix is to force the older dwarf
> > version in the hope that a fixed dwarves release will
> > arrive before Fedora 34 is released, or GCC 11 becomes more
> > widespread. Eventually we might need to figure out a way to
> > probe for compatibility but for now, we'll hope that any
> > distro with GCC 11 will be able to have a fixed dwarves too.
> 
> Hopefully that won't be necessary. This is a good enough fix, but we need to be
> careful with the refreshes for now, so that we accidentally don't overwrite
> this (more of a self-note actually :)). It would also IMO make sense to
> drop the auto-generated header from the Dockerfile to help us spot a potential
> overwrite during review on the next refresh.

Errr, this is changing the gitlab config, not the dockerfiles,
so has no impact on the docker refresh.

> 
> Reviewed-by: Erik Skultety <eskultet at redhat.com>
> 
> > 
> > https://bugzilla.redhat.com/show_bug.cgi?id=1919965
> > Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
> > ---
> >  .gitlab-ci.yml | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> > index 8949adf7a0..5221e8b5b6 100644
> > --- a/.gitlab-ci.yml
> > +++ b/.gitlab-ci.yml
> > @@ -367,6 +367,10 @@ x64-fedora-rawhide:
> >      - x64-fedora-rawhide-container
> >    variables:
> >      NAME: fedora-rawhide
> > +    # Temp workaround until we see what resolution is for
> > +    # https://bugzilla.redhat.com/show_bug.cgi?id=1919965
> > +    # Hopefully remove before F34 is released.
> > +    CFLAGS: -gdwarf-4
> >  
> >  x64-fedora-rawhide-clang:
> >    extends: .native_build_job
> > -- 
> > 2.29.2
> > 

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|