[libvirt PATCH 08/11] tests: Prevent malloc with size 0

Tim Wiederhake twiederh at redhat.com
Thu Jan 28 10:24:38 UTC 2021


Found by clang-tidy's "clang-analyzer-optin.portability.UnixAPI" check.

Signed-off-by: Tim Wiederhake <twiederh at redhat.com>
---
 tests/commandhelper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/commandhelper.c b/tests/commandhelper.c
index ba5681b715..9394a42726 100644
--- a/tests/commandhelper.c
+++ b/tests/commandhelper.c
@@ -99,7 +99,7 @@ int main(int argc, char **argv) {
         origenv++;
     }
 
-    if (!(newenv = malloc(sizeof(*newenv) * n)))
+    if ((n == 0) || !(newenv = malloc(sizeof(*newenv) * n)))
         abort();
 
     origenv = environ;
-- 
2.26.2




More information about the libvir-list mailing list