[PATCH] conf: rename virDomainCheckVirtioOptions

Pavel Hrdina phrdina at redhat.com
Fri Jan 29 12:35:27 UTC 2021

On Fri, Jan 29, 2021 at 12:39:22PM +0100, Boris Fiuczynski wrote:
> Rename virDomainCheckVirtioOptions into
> virDomainCheckVirtioOptionsAreAbent since it checks if all virtio
> options are absent. The old name was very misleading.
> Signed-off-by: Boris Fiuczynski <fiuczy at linux.ibm.com>
> ---
>  src/conf/domain_validate.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

NACK to this patch. I don't see any point in this rename. The whole file
mostly checks if something is missing. If anything I would go for

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20210129/8d4df497/attachment-0001.sig>

More information about the libvir-list mailing list