[PATCH] Increase timeout for tests and syntax-check

Daniel P. Berrangé berrange at redhat.com
Fri Jan 29 12:48:40 UTC 2021


On Wed, Jan 27, 2021 at 06:59:58PM +0100, Michal Privoznik wrote:
> Since we've switched to meson our tests run with a timeout (meson
> uses 30 seconds as the default). However, not every machine that
> builds libvirt is fast enough to run every test under 30 seconds
> (each test binary has its own timeout, but still). For instance
> when building a package for distro on a farm that's under load.
> Or on a generally slow ARM hardware. While each developer can
> tune their command line for building by adding
> --timeout-multiplier=10, this is hard to do for aforementioned
> build farms.

I don't get why it is hard for build farms. Someone, somwhere
is writing the script that invokes meson & ninja with some
args. Why is it hard to add --timeout-multiplier=10 too ?

> It's time to admit that not everybody has the latest, top shelf
> CPU and increase the timeout.

I'm not convinced we want to optimize for the slowest hardware
we can find, especially when there's an easy option of setting
--timeout-multiplier=10.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




More information about the libvir-list mailing list