[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 1/2] qemu_capabilities: Introduce QEMU_CAPS_X_USE_CANONICAL_PATH_FOR_RAMBLOCK_ID



On Tue, Jan 12, 2021 at 09:29:49 +0100, Michal Privoznik wrote:
> This capability tracks whether memory-backend-file has
> "x-use-canonical-path-for-ramblock-id" attribute. Introduced into
> QEMU by commit v4.0.0-rc0~189^2. While "x-" prefix is considered

Please use a commit hash instead of this.

> experimental or internal to QEMU, the next commit justifies its
> use.

NACK unless qemu adds a statement to their code and documentation that
the this property is considered stable despite the 'x-prefix' and you
add a link to the appropriate qemu upstream commit once it's done.

We don't want to depend on experimental stuff so we need a strong
excuse.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]