[PATCHv2 3/4] qemu: interface: remove setting noqueue for ovs port

Michal Prívozník mprivozn at redhat.com
Fri Jul 2 15:46:28 UTC 2021


On 7/1/21 10:42 AM, zhangjl02 wrote:
> From: zhangjl02 <zhangjl02 at inspur.com>
> 
> Return 0 directly if the port is ovs managed. When the ovs port is set
> noqueue, qos config on this port will not work.
> ---
>  src/qemu/qemu_domain.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
> index fc60e15eea..b9485e4fe6 100644
> --- a/src/qemu/qemu_domain.c
> +++ b/src/qemu/qemu_domain.c
> @@ -11526,7 +11526,8 @@ qemuDomainInterfaceSetDefaultQDisc(virQEMUDriver *driver,
>          actualType == VIR_DOMAIN_NET_TYPE_NETWORK ||
>          actualType == VIR_DOMAIN_NET_TYPE_BRIDGE ||
>          actualType == VIR_DOMAIN_NET_TYPE_DIRECT) {
> -        if (virNetDevBandwidthSetRootQDisc(net->ifname, "noqueue") < 0)
> +        if (!virDomainNetDefIsOvsport(net, actualType) &&

This "actualType" argument won't be needed after my suggestion from 1/4.

> +            virNetDevBandwidthSetRootQDisc(net->ifname, "noqueue") < 0)
>              return -1;
>      }
>  
> 

Michal




More information about the libvir-list mailing list