[PATCH 00/10] ch: Add Console support

Michal Prívozník mprivozn at redhat.com
Mon Jul 12 12:05:19 UTC 2021


On 6/30/21 1:05 AM, William Douglas wrote:
> This series enables console support in the cloud-hypervisor driver.
> 
> Cloud-hypervisor only supports a single console or serial device at a
> time, hence the checks to ensure the domain configuration is only
> passing one or the other.
> 
> I wasn't sure if the controller device should have some additonal
> validation handling so I just did the minimal to get the console open
> functioning.
> 
> William Douglas (10):
>   ch_monitor: Make unused function static
>   ch_monitor: Update virCHMonitorGet to handle accept a response
>   ch_monitor: Use virCHMonitorGet to access cloud-hypervisor API
>   ch_monitor: Add pty json builder function
>   ch_monitor: Make use of the PTY json builder
>   ch_process: Handle enabled console devices
>   ch_process: Update the domain with console path information
>   ch_domain: Allow controller and chr devices
>   ch_driver: Add handler for console API
>   ch_driver: Turn on the domainOpenConsole API
> 
>  src/ch/ch_domain.c  |   4 +-
>  src/ch/ch_driver.c  |  78 +++++++++++++++++++++++++++++
>  src/ch/ch_monitor.c | 117 ++++++++++++++++++++++++++++++++++++++++++--
>  src/ch/ch_monitor.h |   3 ++
>  src/ch/ch_process.c |  67 +++++++++++++++++++++++++
>  5 files changed, 263 insertions(+), 6 deletions(-)
> 

Hey, we require that the code is able to compile and test suite passes
after each individual commit (because it's more cherry-pick friendly).
Basically 'ninja -C build/ test' should pass after each commit.

Otherwise, see individual comments.

Michal




More information about the libvir-list mailing list