[libvirt PATCH 6/6] virDomainSEVDefParseXML: Remove superfluous variable initialization
Erik Skultety
eskultet at redhat.com
Mon Jul 12 14:26:30 UTC 2021
On Mon, Jul 05, 2021 at 12:46:54PM +0200, Tim Wiederhake wrote:
> Signed-off-by: Tim Wiederhake <twiederh at redhat.com>
> ---
> src/conf/domain_conf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
> index db8ec23d70..2d8ae7e860 100644
> --- a/src/conf/domain_conf.c
> +++ b/src/conf/domain_conf.c
> @@ -14721,7 +14721,7 @@ virDomainSEVDefParseXML(xmlNodePtr sevNode,
> VIR_XPATH_NODE_AUTORESTORE(ctxt)
> g_autoptr(virDomainSEVDef) def = NULL;
> unsigned long policy;
> - int rc = -1;
> + int rc;
This is just a pointless nitpick (given that this has already been pushed),
but initializing a variable at the time of its definition is actually a good
practice, so there was really no point in this patch, the only bad thing about
the code segment is that we're inconsistent.
Regards,
Erik
More information about the libvir-list
mailing list