[libvirt PATCH 10/10] virNWFilterDHCPSnoopInit: `virHashNew` cannot return NULL

Tim Wiederhake twiederh at redhat.com
Tue Jul 13 14:44:41 UTC 2021


Signed-off-by: Tim Wiederhake <twiederh at redhat.com>
---
 src/nwfilter/nwfilter_dhcpsnoop.c | 17 -----------------
 1 file changed, 17 deletions(-)

diff --git a/src/nwfilter/nwfilter_dhcpsnoop.c b/src/nwfilter/nwfilter_dhcpsnoop.c
index 2481ea5371..4b62a7b661 100644
--- a/src/nwfilter/nwfilter_dhcpsnoop.c
+++ b/src/nwfilter/nwfilter_dhcpsnoop.c
@@ -1998,27 +1998,10 @@ virNWFilterDHCPSnoopInit(void)
     virNWFilterSnoopState.snoopReqs =
         virHashNew(virNWFilterSnoopReqRelease);
 
-    if (!virNWFilterSnoopState.ifnameToKey ||
-        !virNWFilterSnoopState.snoopReqs ||
-        !virNWFilterSnoopState.active)
-        goto error;
-
     virNWFilterSnoopLeaseFileLoad();
     virNWFilterSnoopLeaseFileOpen();
 
     return 0;
-
- error:
-    virHashFree(virNWFilterSnoopState.ifnameToKey);
-    virNWFilterSnoopState.ifnameToKey = NULL;
-
-    virHashFree(virNWFilterSnoopState.snoopReqs);
-    virNWFilterSnoopState.snoopReqs = NULL;
-
-    virHashFree(virNWFilterSnoopState.active);
-    virNWFilterSnoopState.active = NULL;
-
-    return -1;
 }
 
 /**
-- 
2.31.1




More information about the libvir-list mailing list