[libvirt PATCH v2 03/10] virNWFilterCreateVarsFrom: Remove superfluous `goto`s

Tim Wiederhake twiederh at redhat.com
Tue Jul 13 15:12:05 UTC 2021


Signed-off-by: Tim Wiederhake <twiederh at redhat.com>
Reviewed-by: Peter Krempa <pkrempa at redhat.com>
---
 tests/nwfilterxml2firewalltest.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/tests/nwfilterxml2firewalltest.c b/tests/nwfilterxml2firewalltest.c
index 26d4a936ad..bdfe858185 100644
--- a/tests/nwfilterxml2firewalltest.c
+++ b/tests/nwfilterxml2firewalltest.c
@@ -151,15 +151,12 @@ virNWFilterCreateVarsFrom(GHashTable *vars1,
     g_autoptr(GHashTable) res = virHashNew(virNWFilterVarValueHashFree);
 
     if (virNWFilterHashTablePutAll(vars1, res) < 0)
-        goto err_exit;
+        return NULL;
 
     if (virNWFilterHashTablePutAll(vars2, res) < 0)
-        goto err_exit;
+        return NULL;
 
     return g_steal_pointer(&res);
-
- err_exit:
-    return NULL;
 }
 
 
-- 
2.31.1




More information about the libvir-list mailing list