[PATCH] Use postfix increment

Peter Krempa pkrempa at redhat.com
Wed Jul 14 07:04:26 UTC 2021


On Tue, Jul 13, 2021 at 14:18:24 +0200, Michal Prívozník wrote:
> On 7/13/21 11:11 AM, Peter Krempa wrote:
> > On Tue, Jul 13, 2021 at 08:44:06 +0200, Michal Privoznik wrote:
> >> We document that our coding style is to use postfix increment in
> >> for() loops rather than prefix. This change was generated by the
> >> following sed script:
> >>
> >>   for i in $(git grep -l "for (.*; ++.*)"); do \
> >>     sed -i 's/\(for (.*; \)++\(.*\))/\1\2++)/' $i; \
> >>   done
> >>
> >> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> >> ---
> > 
> > NACK this is mostly pointless churn.
> > 
> 
> Fair enough. I just wanted us to be compliant with our coding style
> guide. But I can live with this patch unmerged.

I'll be okay if you add a syntax check, but just fixing it is not worth
it in this instance.




More information about the libvir-list mailing list