[PATCH v1] virtqemud: remove sysconfig file

[Daniel P. Berrangé]

On Fri, Jul 16, 2021 at 10:31:11AM +0200, Olaf Hering wrote:
> Am Fri, 16 Jul 2021 00:58:43 -0700
> schrieb Andrea Bolognani <abologna at redhat.com>:
> 
> > The sysconfig files shipped with libvirt contain the defaults, and
> > the admin is absolutely welcome to tweak them however they might like
> > after installation, just as is the case for all the configuration
> > files in /etc/libvirt.
> 
> Right. Once they are modified for whatever reason things will go downhill.
> 
> Just recently the default (for libvirtd) changed from --listen to --timeout.
> This is an incompatible change.

The --listen parameter was never the default, it only ever existed in
commented out form, similarly today the tcp/tls socket units should
not be enabled by default, because they require auth configuration
before use.

The addition of --timeout parameter was combined with introdution of
socket activation, so should be essentially transparent

> If --listen would have been configured like I proposed, any admin changes are
> clear and obvious, and he has to keep the pieces if it falls apart because
> some default changed. In this case from .service to .socket activation.

I don't see that would have made any change since --listen was not enabled
either before / after the changes.

Originally the sysconfig file provided a way to override the initscripts
config, and was kept with systemd units essentially because it already
exists. Now that initscripts are completely gone, the sysconfig possibly
doesn't need to exist, as it is already posible to override unit files in
a reasonably simple manner.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|