[PATCH 1/2] docs: Allow 'id' attribute for 'cachetune' element
Michal Prívozník
mprivozn at redhat.com
Mon Jul 19 10:12:57 UTC 2021
On 7/16/21 12:15 PM, Kristina Hanicova wrote:
> Even though 'id' attribute is output-only, we should accept xml
> files containing it.
>
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1941594
>
> Signed-off-by: Kristina Hanicova <khanicov at redhat.com>
> ---
> docs/formatdomain.rst | 2 +-
> docs/schemas/domaincommon.rng | 5 +++++
> 2 files changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst
> index 25e6bf73ba..d3c91c2a6d 100644
> --- a/docs/formatdomain.rst
> +++ b/docs/formatdomain.rst
> @@ -850,7 +850,7 @@ CPU Tuning
> to which vCPUs this allocation applies. A vCPU can only be member of one
> ``cachetune`` element allocation. The vCPUs specified by cachetune can be
> identical with those in memorytune, however they are not allowed to overlap.
> - Supported subelements are:
> + The optional attribute ``id`` is output only. Supported subelements are:
How about: The optional, output only ``id`` attribute identifies cache
uniquely.
>
> ``cache``
> This optional element controls the allocation of CPU cache and has the
> diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng
> index 5ea14b6dbf..c6643bbc7f 100644
> --- a/docs/schemas/domaincommon.rng
> +++ b/docs/schemas/domaincommon.rng
> @@ -1006,6 +1006,11 @@
> <attribute name="vcpus">
> <ref name="cpuset"/>
> </attribute>
> + <optional>
> + <attribute name="id">
> + <data type="string"/>
> + </attribute>
> + </optional>
> <oneOrMore>
> <choice>
> <element name="cache">
>
Michal
More information about the libvir-list
mailing list