[PATCH 2/2] tests: Modify to test output value of <cachetune id=''

Michal Prívozník mprivozn at redhat.com
Mon Jul 19 10:12:56 UTC 2021


On 7/16/21 12:15 PM, Kristina Hanicova wrote:
> We can also delete out xml thanks to the change in the call of
> the test to DO_TEST instead of DO_TEST_DIFFERENT.

I think the subject can be formatted better:

genericxml2xmltest: Modify cachetune test to include id

Alternatively, the element should be ended, like this: <cachetune id''/>

And in the commit message you can explain why you want to change
DO_TEST_DIFFERENT() to DO_TEST() - esp. that part about live XML.

Michal




More information about the libvir-list mailing list