[PATCH v2 1/2] docs: Allow 'id' attribute for 'cachetune' element

Kristina Hanicova khanicov at redhat.com
Tue Jul 20 12:58:08 UTC 2021


Even though 'id' attribute is output-only, we should accept xml
files containing it.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1941594

Signed-off-by: Kristina Hanicova <khanicov at redhat.com>
---
 docs/formatdomain.rst         | 1 +
 docs/schemas/domaincommon.rng | 5 +++++
 2 files changed, 6 insertions(+)

diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst
index 25e6bf73ba..b14fba2cd1 100644
--- a/docs/formatdomain.rst
+++ b/docs/formatdomain.rst
@@ -850,6 +850,7 @@ CPU Tuning
    to which vCPUs this allocation applies. A vCPU can only be member of one
    ``cachetune`` element allocation. The vCPUs specified by cachetune can be
    identical with those in memorytune, however they are not allowed to overlap.
+   The optional, output only ``id`` attribute identifies cache uniquely.
    Supported subelements are:
 
    ``cache``
diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng
index 5ea14b6dbf..c6643bbc7f 100644
--- a/docs/schemas/domaincommon.rng
+++ b/docs/schemas/domaincommon.rng
@@ -1006,6 +1006,11 @@
             <attribute name="vcpus">
               <ref name="cpuset"/>
             </attribute>
+            <optional>
+              <attribute name="id">
+                <data type="string"/>
+              </attribute>
+            </optional>
             <oneOrMore>
               <choice>
                 <element name="cache">
-- 
2.31.1




More information about the libvir-list mailing list