[PATCH 17/33] qemu: Remove return value from qemuMonitorDomainBalloonChangeCallback

Peter Krempa pkrempa at redhat.com
Wed Jul 21 10:42:29 UTC 2021


Change the callback prototype and fix the callback registered in the
process code.

Signed-off-by: Peter Krempa <pkrempa at redhat.com>
---
 src/qemu/qemu_monitor.h | 8 ++++----
 src/qemu/qemu_process.c | 3 +--
 2 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/src/qemu/qemu_monitor.h b/src/qemu/qemu_monitor.h
index d678205bc0..fa3d0e1922 100644
--- a/src/qemu/qemu_monitor.h
+++ b/src/qemu/qemu_monitor.h
@@ -227,10 +227,10 @@ typedef void (*qemuMonitorDomainPMWakeupCallback)(qemuMonitor *mon,
 typedef void (*qemuMonitorDomainPMSuspendCallback)(qemuMonitor *mon,
                                                    virDomainObj *vm,
                                                    void *opaque);
-typedef int (*qemuMonitorDomainBalloonChangeCallback)(qemuMonitor *mon,
-                                                      virDomainObj *vm,
-                                                      unsigned long long actual,
-                                                      void *opaque);
+typedef void (*qemuMonitorDomainBalloonChangeCallback)(qemuMonitor *mon,
+                                                       virDomainObj *vm,
+                                                       unsigned long long actual,
+                                                       void *opaque);
 typedef int (*qemuMonitorDomainPMSuspendDiskCallback)(qemuMonitor *mon,
                                                       virDomainObj *vm,
                                                       void *opaque);
diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index 74a8bc7214..421b9b5f11 100644
--- a/src/qemu/qemu_process.c
+++ b/src/qemu/qemu_process.c
@@ -1202,7 +1202,7 @@ qemuProcessHandlePMSuspend(qemuMonitor *mon G_GNUC_UNUSED,
     virObjectEventStateQueue(driver->domainEventState, lifecycleEvent);
 }

-static int
+static void
 qemuProcessHandleBalloonChange(qemuMonitor *mon G_GNUC_UNUSED,
                                virDomainObj *vm,
                                unsigned long long actual,
@@ -1225,7 +1225,6 @@ qemuProcessHandleBalloonChange(qemuMonitor *mon G_GNUC_UNUSED,
     virObjectUnlock(vm);

     virObjectEventStateQueue(driver->domainEventState, event);
-    return 0;
 }

 static int
-- 
2.31.1




More information about the libvir-list mailing list