[libvirt PATCH 23/38] virFileCacheNew: `virHashNew` cannot return NULL

Tim Wiederhake twiederh at redhat.com
Thu Jul 22 07:50:15 UTC 2021


Signed-off-by: Tim Wiederhake <twiederh at redhat.com>
---
 src/util/virfilecache.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/src/util/virfilecache.c b/src/util/virfilecache.c
index 2f55deefb6..64348dc1e6 100644
--- a/src/util/virfilecache.c
+++ b/src/util/virfilecache.c
@@ -242,8 +242,7 @@ virFileCacheNew(const char *dir,
     if (!(cache = virObjectNew(virFileCacheClass)))
         return NULL;
 
-    if (!(cache->table = virHashNew(virObjectFreeHashData)))
-        goto cleanup;
+    cache->table = virHashNew(virObjectFreeHashData);
 
     cache->dir = g_strdup(dir);
 
@@ -252,10 +251,6 @@ virFileCacheNew(const char *dir,
     cache->handlers = *handlers;
 
     return cache;
-
- cleanup:
-    virObjectUnref(cache);
-    return NULL;
 }
 
 
-- 
2.31.1




More information about the libvir-list mailing list