[libvirt PATCH] virsh: fix setmem flags logic
Michal Prívozník
mprivozn at redhat.com
Fri Jul 23 09:02:10 UTC 2021
On 7/23/21 10:35 AM, Pavel Hrdina wrote:
> When we dropped virDomainSetMemory usage it got kind of tricky to
> figure out the flags correctly.
>
> Originally the logic was following:
>
> no option | --current | --live | --config | --live --config
> ----------+-----------+--------+----------+----------------
> LIVE | CURRENT | LIVE | CONFIG | LIVE & CONFIG
>
> But after the commit removing virDomainSetMemory usage it changed to:
>
> no option | --current | --live | --config | --live --config
> ----------+-----------+--------+-----------------+----------------
> LIVE | CURRENT | LIVE | LIVE & CONFIG | LIVE & CONFIG
>
> This commit fixes the logic back to the original behavior except for
> ESX, HyperV and Virtuozzo drivers where virDomainSetMemory() default
> behavior was CURRENT instead of LIVE.
>
> Fixes: ce8138564bba0def7d7195814fba4555915d60d5
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1980199
> Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
> ---
> tools/virsh-domain.c | 11 ++++++++---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
Oops.
Reviewed-by: Michal Privoznik <mprivozn at redhat.com>
Michal
More information about the libvir-list
mailing list