Turning off -Werror

[Richard W.M. Jones]

On Wed, Jul 28, 2021 at 11:31:13AM +0100, Daniel P. Berrangé wrote:
> On Wed, Jul 28, 2021 at 11:20:27AM +0100, Richard W.M. Jones wrote:
> > 
> >   commit 3c3c55be66e230ef09ad927eda038dc32f01a166
> >   Author: Daniel P. Berrangé <berrange at redhat.com>
> >   Date:   Thu Apr 8 11:50:30 2021 +0100
> > 
> >     meson: don't probe for -Werror if --werror is enabled
> > 
> > Builds are failing in Fedora Rawhide at the moment because of a
> > warning being turned into an error.  Fedora's spec file has this which
> > is supposed to turn off -Werror, but it no longer works after the
> > above commit was added.
> 
> I don't believe that commit made a difference. Prior to that commit,
> libvirt would always add Werror if biulding from git, even if meson
> had already added Werror, causing a warning from meson.
> 
> Now we only add Werror if building from git and meson has not already
> added Werror itself.
> 
> > https://src.fedoraproject.org/rpms/libvirt/blob/rawhide/f/libvirt.spec#_189
> > 
> > I'm trying to understand how you're supposed to turn off -Werror.
> > According to meson documentation omitting --werror should work.
> > According to some different docs, use --werror=false.  Neither are
> > working for me.
> 
> Normally -Dwerror=false would be sufficient for building from the
> tarball, but in the RPM we're using git to manage patches, so we
> need both options:
> 
>    -Dwerror=false -Dgit_werror=disabled

I made this change in Rawhide, so let's see how it goes ...

https://src.fedoraproject.org/rpms/libvirt/c/7744acbb6bb8e88f28d3cbf7671741483964b95e?branch=rawhide
https://koji.fedoraproject.org/koji/taskinfo?taskID=72834651

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-builder quickly builds VMs from scratch
http://libguestfs.org/virt-builder.1.html