[PATCH] rpm: properly disble -Werror

Daniel P. Berrangé berrange at redhat.com
Wed Jul 28 15:12:59 UTC 2021


On Wed, Jul 28, 2021 at 05:11:27PM +0200, Michal Prívozník wrote:
> On 7/28/21 4:14 PM, Daniel P. Berrangé wrote:
> > Since we use git to manage RPM applied patches, we need to disable both
> > meson's -Werror config knob and libvirt's equivalent.
> > 
> > Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
> > ---
> >  libvirt.spec.in | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/libvirt.spec.in b/libvirt.spec.in
> > index cb48dd0be0..b09336b441 100644
> > --- a/libvirt.spec.in
> > +++ b/libvirt.spec.in
> > @@ -192,7 +192,7 @@
> >  %if 0%{?rhel}
> >      %define enable_werror -Dwerror=true
> >  %else
> > -    %define enable_werror -Dwerror=false
> > +    %define enable_werror -Dwerror=false -Wgit_werror=disabled
> 
> I think you meant -Dgit_werror=disabled.

Yes, of course. 🤦 🤦


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




More information about the libvir-list mailing list